Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Move Vite/Nitro integration into a standalone plugin #318

Closed
2 tasks
brandonroberts opened this issue Apr 3, 2023 · 4 comments
Closed
2 tasks
Assignees
Labels
enhancement New feature or request

Comments

@brandonroberts
Copy link
Member

Which scope/s are relevant/related to the feature request?

platform

Information

Currently Analog uses Nitro underneath as its server engine, configured through an internal Vite plugin. This feature would separate the internal Vite/Nitro plugin from @analogjs/platform plugin into its package as @analogjs/vite-plugin-nitro.

This plugin would be framework agnostic and able to be used in any Vite application.

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@brandonroberts brandonroberts added the enhancement New feature or request label Apr 3, 2023
@Yberion
Copy link
Contributor

Yberion commented Apr 4, 2023

What if we don't want to use nitro at all but use our own server implementation ?

You did something here Yberion/Angular-SSR-Common-Engine#1, but from what I remember, it was still using nitro behind the scene and I would suspect that it could add some overhead and reduce the performance (I might be wrong).

It would be nice to have another plugin that don't rely on nitro for the server integration, something such as @analogjs/vite-plugin-server-common (or anything else)?

@brandonroberts
Copy link
Member Author

It was using Nitro to build the server app, but none of the Nitro parts were being used there. Creating a separate plugin for server integration would also require building a new process for prerendering pages also.

It's possible, but would be a more substantial effort.

@goetzrobin
Copy link
Member

I can work on this! Also open to look at another issue! Let me know where you think my time is spent best! 🚀

@brandonroberts
Copy link
Member Author

You're welcome to pick it up! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants