-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monky-get-root-dir doesn't work with remote repositories #25
Conversation
When we use filenames returned by hg commands, we need to convert them to tramp paths, if needed. This patch fixes only monky-status; others may be needed
This works great for me in my limited testing. |
I struggle to understand how Tramp syntax for a remote path and Hg syntax for a remote can "work together"? Can you please provide and example |
If you call out to hg with the correct emacs functions, emacs is smart enough to run the process on the remote host. |
Do you have an example? |
I'm pretty sure you're already doing this correctly - that is, if you apply this patch, then most things Just Work. |
I just want to understand what feature this patch is implementing, before merging it. |
There really isn't anything Mercurial specific here. It's just Tramp and mounting files over ssh. If you call However, if you juggle this right, then emacs will shell out to calling Hopefully, that explains enough to show that this is mostly a Tramp issue which happens to shell out to Mercurial (perhaps it's confusing that Tramp / git / hg all have a 'remote' concept that differs here). |
@seanfarley Thanks for the explanation, it is clear now. |
Sorry for not replying before. I realize the description of the issue is not really correct. As @seanfarley pointed out the issue was not much with remote repositories, as with remote working directories. |
monky-get-root-dir uses "hg root" to get the root for the repository.
When we are working with remote repositories, we need to convert the output to a tramp path.