Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License? #34

Closed
xiaq opened this issue Nov 10, 2022 · 6 comments
Closed

License? #34

xiaq opened this issue Nov 10, 2022 · 6 comments

Comments

@xiaq
Copy link
Contributor

xiaq commented Nov 10, 2022

Hi! I am trying to set up Cirrus CI tasks to run on OpenBSD and NetBSD and a series of links from cirruslabs/cirrus-ci-docs#970 eventually led me here :)

I see you already have some pretty sophisticated Packer scripts for building those images, so I wish to be able to reuse them. But this repo doesn't seem to have a license file - do you mind clarifying which license the code is?

Also, it would be great if the OpenBSD and NetBSD images in pg-ci-images are public (Cirrus CI has the relevant gcloud command documented) :) From my cursory read of the Packer scripts these images don't contain anything confidential, and AFAIK making images public won't incur any additional cost.

@nbyavuz
Copy link
Collaborator

nbyavuz commented Nov 10, 2022

Hi @xiaq! The images should be public, the gcloud command you mentioned is already run while creating the images.

@xiaq
Copy link
Contributor Author

xiaq commented Nov 10, 2022

@nbyavuz Thanks! Indeed I can see the latest vanilla netbsd-vanilla image:

xiaqqaix@cloudshell:~$ gcloud compute images describe --project pg-ci-images pg-ci-netbsd-vanilla-2022-11-09t21-31-00
archiveSizeBytes: '379914048'
creationTimestamp: '2022-11-09T13:48:55.946-08:00'
diskSizeGb: '25'
family: pg-ci-netbsd-vanilla
id: '9066439252212031144'
kind: compute#image
labelFingerprint: 42WmSpB8rSM=
name: pg-ci-netbsd-vanilla-2022-11-09t21-31-00
rawDisk:
  containerType: TAR
  source: ''
selfLink: https://www.googleapis.com/compute/v1/projects/pg-ci-images/global/images/pg-ci-netbsd-vanilla-2022-11-09t21-31-00
sourceType: RAW
status: READY
storageLocations:
- us

Still, two requests :)

  • It'd still be useful to know what the code is licensed under :)

  • It's quite nontrivial to know the names of the images - I had to look at Cirrus CI's logs to track them down. Is it possible to allow all authenticated users to list images? There is a separate permission for that:

    xiaqqaix@cloudshell:~$ gcloud compute images list --project pg-ci-images --no-standard-images
    ERROR: (gcloud.compute.images.list) Some requests did not succeed:
     - Required 'compute.images.list' permission for 'projects/pg-ci-images'
    

    For reference I am already able to do this with another GCP project that contains FreeBSD images: gcloud compute images list --project freebsd-org-cloud-dev --no-standard-images

@xiaq
Copy link
Contributor Author

xiaq commented Nov 10, 2022

Hmm, I do have the permission to find the latest image from a family (I can run gcloud compute images describe-from-family --project pg-ci-images pg-ci-netbsd-vanilla), so the ability to list images is not that important but still would be nice to have :)

@anarazel
Copy link
Owner

It'd still be useful to know what the code is licensed under :)

Indeed. I'll add the proper files. The contents of the repository are under the postgresql license (of course the images etc aren't, we can't relicense the files therein).

Required 'compute.images.list' permission for 'projects/pg-ci-images'

Yea, I see no reason not to grant that. Will do that in a few.

@anarazel
Copy link
Owner

@xiaq

Added a LICENSE.

Unfortunately I couldn't figure out how to grant compute.images.list to everyone. It's not allowed to grant project level roles to allUsers or allAuthenticatedUsers (" Error: Principals of type allUsers and allAuthenticatedUsers cannot be added to this resource " in the UI, something slightly more verbose on the commandline). I do not know how freebsd did so. I tried to find their scripts for managing the gcp account, but couldn't. I'd be happy to do this if you can point me in the right direction.

@xiaq
Copy link
Contributor Author

xiaq commented Nov 20, 2022

@anarazel Thanks for clarifying the license!

I'm not that familiar with GCP's permission model so I don't know the answer. I suppose just documenting how to find the image (project name and image family name) may be a good enough substitute for people interested in using them.

@xiaq xiaq closed this as completed Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants