Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup dotenv #101

Closed
roopeshsn opened this issue Aug 1, 2023 · 2 comments
Closed

Setup dotenv #101

roopeshsn opened this issue Aug 1, 2023 · 2 comments
Labels
feat/enhancement New feature or request good first issue Good for newcomers SWAG

Comments

@roopeshsn
Copy link

roopeshsn commented Aug 1, 2023

By setting up python-dotenv, the environment variables can be loaded from a .env file, which is in the root. And, I would like to work on this.

@mmirman mmirman added feat/enhancement New feature or request good first issue Good for newcomers SWAG labels Aug 6, 2023
@dorkitude
Copy link
Collaborator

This should be achievable using dynaconf in lieu of python-dotenv, but it's possible we have a bug in the .env loader.

Want to take a look at our logic, @roopeshsn ?

The relevant section to test is in /src/llm_vm/config.py:

settings = Dynaconf(
    settings_file=config_files,
    load_dotenv=True,
    dotenv_path=".env",
    envvar_prefix="LLM_VM",
)

@cartazio
Copy link
Contributor

cartazio commented Aug 7, 2023

i think we have a config system already, so closing for now, please comment if i'm incorrect

@cartazio cartazio closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat/enhancement New feature or request good first issue Good for newcomers SWAG
Projects
None yet
Development

No branches or pull requests

4 participants