Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling catalogers is not working in power user command #2074

Closed
tomerse-sg opened this issue Aug 29, 2023 · 1 comment · Fixed by #2001
Closed

Disabling catalogers is not working in power user command #2074

tomerse-sg opened this issue Aug 29, 2023 · 1 comment · Fixed by #2001
Assignees
Labels
bug Something isn't working

Comments

@tomerse-sg
Copy link

What happened:
i'm trying to disable a power-user cataloger using the .syft.yaml and it ignores it.
I think it is always puts "true" and don't take the value from the configuration.

		app.Secrets.Cataloger.Enabled = true
		app.FileMetadata.Cataloger.Enabled = true
		app.FileContents.Cataloger.Enabled = true
		app.FileClassification.Cataloger.Enabled = true
		tasks, err := eventloop.Tasks(app)
		if err != nil {
			errs <- err
			return
		}

What you expected to happen:
take the value from the configuration.
Steps to reproduce the issue:
for example, update this line in the yaml:

file-metadata:
  cataloger:
    # enable/disable cataloging of file metadata
    # SYFT_FILE_METADATA_CATALOGER_ENABLED env var
    enabled: false

and run syft power-user
Anything else we need to know?:

Environment:

  • Output of syft version: latest
  • OS (e.g: cat /etc/os-release or similar): macOS
@tomerse-sg tomerse-sg added the bug Something isn't working label Aug 29, 2023
@kzantow
Copy link
Contributor

kzantow commented Aug 29, 2023

FYI @tomerse-sg -- this PR should fix this issue: #2001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants