This repository has been archived by the owner on Aug 27, 2022. It is now read-only.
stabilized rotary encoder handling #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: If5678c7a1f8be7fe9c9e64773583246cbc92fb0e
jacques42
approved these changes
Jun 16, 2022
There was a problem hiding this comment.
Hey - makes sense to me and seems like you also fixed another bug (where I confused Pins in the code). In a future release I will make 'cnt' a slider in the expert settings of admin for rotary and name it 'sensitivity'. So people can adjust depending on their Hardware rotary switch
|
Yeah - that's a really good idea to integrate a slider to expert view. I also thought about this solution. |
marco-117
added a commit
to marco-117/photobooth
that referenced
this pull request
Aug 2, 2022
Bug fixed: in pull request andi34#449 the direction detection was override by the same pin. Update: when changing the direction, you may have to make more than 3 clicks. By resetting the counter on the first click in the new dirction this problem is solved.
andi34
pushed a commit
that referenced
this pull request
Aug 5, 2022
Bug fixed: in pull request #449 the direction detection was override by the same pin. Update: when changing the direction, you may have to make more than 3 clicks. By resetting the counter on the first click in the new dirction this problem is solved. Change-Id: If41f60a9f8aa5c005e9afdc37bc640e3f157b355
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
Cleaned up #441