VALUES was incorrectly treated as a function #64
Merged
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andialbrecht
added a commit
that referenced
this pull request
Apr 23, 2012
VALUES was incorrectly treated as a function
|
Thanks! I'll add a comment pointing to this pull request since it seems to be an issue with the parsing/grouping order. I'd expected that the "VALUES" keyword listed in keywords.py solves this issue, but obviously it didn't. :) |
ovr
pushed a commit
to cube-js/sqlparse
that referenced
this pull request
Dec 26, 2020
Implement COLLATE, optional column list in CTEs, and more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the version of sqlparse in debian, (INSERT...) VALUES was treated as a function. Then I broke it somehow with my changes to the lexer so it was grouped with table name: <Identifier 'test V...' at 0xb732982c>.
This fix is probably not ideal to solve the issue, but I wanted to submit a fix of some sort as I broke it.