Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trunk version of toplev regressed in generation of valid groups #504

Closed
aayasin opened this issue Dec 14, 2023 · 1 comment
Closed

Trunk version of toplev regressed in generation of valid groups #504

aayasin opened this issue Dec 14, 2023 · 1 comment
Labels
invalid perf-tools issues impacting use in perf-tools

Comments

@aayasin
Copy link
Collaborator

aayasin commented Dec 14, 2023

Can be reproduced with PYTHON1s test:

Previous good toplev version (called old in below grep output) is b85ebff

$ grep num run-tl-*stat
run-tl-new.ICX.stat:num-zero-stats 12
run-tl-new.ICX.stat:num-not_counted-stats 85
run-tl-old.ICX.stat:num-zero-stats 97
run-tl-old.ICX.stat:num-not_counted-stats 0

reproducer on ICX:
$ /home/admin1/ayasin/perf-tools/pmu-tools/toplev.py --no-desc -vl6 --nodes '+IPC,+Instructions,+UopPI,+Time,+SLOTS,+CLKS,+Mispredictions,+Big_Code,+Instruction_Fetch_BW,+Branching_Overhead,+DSB_Misses,+Cache_Memory_Bandwidth,+Cache_Memory_Latency,+Memory_Data_TLBs,+Memory_Synchronization,+Compute_Bound_Est,+Irregular_Overhead,+Other_Bottlenecks,+Base_Non_Br' -V tl47-grouping-regress.toplev-vl6-perf.csv --frequency --metric-group +Summary --single-thread --tune 'DEDUP_NODE = "MEM_Parallel_Reads,Lock_Latency,Slots_Utilization,Power,L2_Bound,Big_Code,DSB_Misses,IC_Misses,Contested_Accesses,Data_Sharing,PMM_Bound,Memory_Operations,DRAM_Bound,Other_Light_Ops,Mispredictions,Cache_Memory_Bandwidth,Cache_Memory_Latency,Memory_Data_TLBs,Memory_Synchronization,Base_Non_Br,Instruction_Fetch_BW,Irregular_Overhead,Core_Bound_Likely,Branch_Misprediction_Cost,Other_Bottlenecks"' --perf-output tl47-grouping-regress.toplev-vl6-perf-output.csv -- ./pmu-tools/workloads/PYTHON1s tl47-grouping-regress

$ grep -c 'not counted' tl47-grouping-regress.toplev-vl6-perf*
tl47-grouping-regress.toplev-vl6-perf.csv:115
tl47-grouping-regress.toplev-vl6-perf-output.csv:115
@aayasin aayasin added the perf-tools issues impacting use in perf-tools label Dec 14, 2023
@andikleen
Copy link
Owner

Seems to be a problem with the test system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid perf-tools issues impacting use in perf-tools
Projects
None yet
Development

No branches or pull requests

2 participants