fix owner detection for failed case-aware indexing

andk · Mar 2, 2013 · 02e8280 · 02e8280
1 parent f95fe81
commit 02e8280
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/lib/PAUSE.pm b/lib/PAUSE.pm
@@ -304,6 +304,7 @@ sub user_is {
   return $ret;
 }
 
+# must be case-insensitive
 sub owner_of_module {
     my($m, $dbh) = @_;
     $dbh ||= dbh();
@@ -313,14 +314,11 @@ sub owner_of_module {
                    FROM mods where modid = ?},
                  primeur => qq{SELECT package,
                           userid
-                   FROM primeur where package = ?},
+                   FROM primeur where LOWER(package) = LOWER(?)},
                 );
     for my $table (qw(mods primeur)) {
-        my $sth = $dbh->prepare($query{$table});
-        $sth->execute($m);
-        if ($sth->rows >= 1) {
-            return $sth->fetchrow_array; # ascii guaranteed
-        }
+        my $owner = $dbh->selectrow_arrayref($query{$table}, undef, $m);
+        return $owner->[0] if $owner;
     }
     return;
 }

diff --git a/lib/PAUSE/package.pm b/lib/PAUSE/package.pm
@@ -217,7 +217,7 @@ sub perm_check {
       $pp->{version} = '' unless defined $pp->{version}; # accept version 0
 
       my($p,$owner,@owner);
-      @owner = map { $_[1] } @$auth_ids;
+      @owner = map { $_->[1] } @$auth_ids;
       if ($self->{FIO}{DIO}->isa_regular_perl($dist)) {
           # seems ok: perl is always right
       } elsif (! grep { $_ eq $userid } @owner) {