-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.25 cent Minimum? #6
Comments
Hello! No this is by design since for my needs, I don't really sell cheaper cards than that. However, I see why you would want to be able to change the lowest price. I will add it as a feature request and try to make it a setting. I just have to see that my algorithm doesn't start doing weird things. :) |
Nice, and thanks for considering! Anyway I think that adding some more configuration features like "min price per rarity" or a feature like "Update stock prices per rarity" could help make the tool even more attractive. Cheers, Jan |
Aside from some solid defaults I think it would be awesome if you could dynamically import custom algorithms for yourself. |
Intersting for sure. I will look into it. |
Configurable price rounding limits per rarity are now in the development branch. Will push a release soon. :) |
Now pushed to master and released. Please try it out and get back with feedback. @Shantu58 I looked into custom price algorithm, and while it is doable, it would depend a lot on what kind of customization you want to do. Old price --> New price need some kind of external parameters, such as market trends or comparisons to existing products in stock. I suggest you modify the code yourself and come up with an example of what kind of changes you would like. |
Hi @andli, thanks for this nice tool. I have a small issue though:
From the docs I understood that the tool would use the trend price provided by the cardmarket.
I am using PyMKM 1.0.2 and recently ran an "Update stock prices" for the first time. Unfortunately, the minimum price that is set by the tool seems to be 0.25 cent, for all sorts of cards which is not really competitive, especially for non-foil commons with a trend price of e.g. 0.03 cent.
Could this be a bug or am I missing something?
The text was updated successfully, but these errors were encountered: