-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recent async-hook update breaks trace on node v4 #24
Comments
I can't recommend running
You are correct. However Thus
The above rules means that you can use Unfortunately npm doesn't check your node version and there is no flag to enable that. Thus the best you can do is to remove the
No you are not. I have been thinking about removing Eventually the |
Hey there – thanks for the thoughtful response, sorry for the delay in replying (and the accidental commit-spam!) Completely understand all your points, it sounds a nightmare trying to keep in sync with a private API. For me, the additional error information is definitely worth the performance hit, but if it's not for production use then I guess you could put a warning on the readme? (also that it requires node v5?) Up to you of course. I didn't realize you also made Thanks! |
Yeah, I had such a warning a long time ago, I should properly get that back. |
Node.js v4.5.0 is now available. This has the latest AsyncWrap API and thus |
Hi there – thanks for trace, it's saved my neck countless times!
I'm running Node LTS (v4) in production, and a recent update to
async-hook
has meant that callingrequire('trace')
now breaks my app.I notice that since v1.3.0,
async-hook
now only supports Node v5. Seeing as this was only a minor semver bump to theasync-hook
module (despite being a breaking change), that means thattrace
will depend on the new version, and therefore implicitly requires node v5.I imagine I'm not the only one running the LTS version of node – is there a way we can get
trace
working on v4 as well as v5? Thanks!The text was updated successfully, but these errors were encountered: