Bugfix: allow editing empty JSLink

andrei-markeev · Mar 17, 2017 · ab6636a · ab6636a
1 parent ddf5e37
commit ab6636a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/Code/SharePoint/SPActions.ts b/Code/SharePoint/SPActions.ts
@@ -370,7 +370,7 @@ module CSREditor {
                 context.load(properties);
 
                 context.executeQueryAsync(function () {
-                    window["g_Cisar_JSLink"] = properties.get_item("JSLink").toLowerCase();
+                    window["g_Cisar_JSLink"] = (properties.get_item("JSLink") || "").toLowerCase();
                 },
                 function () {
                     window["g_Cisar_JSLink"] = 'error';
@@ -485,7 +485,7 @@ module CSREditor {
                 context.load(properties);
 
                 context.executeQueryAsync(function () {
-                    var oldJsLinkString = properties.get_item("JSLink").toLowerCase();
+                    var oldJsLinkString = (properties.get_item("JSLink") || "").toLowerCase();
 
                     var toCheck = [];
                     if (path.indexOf(_spPageContextInfo.webServerRelativeUrl) == 0) {
@@ -569,7 +569,7 @@ module CSREditor {
             return "(" + SPActions.waitForGlobal + ")('" + globalVar + "');";
         }
         private static waitForGlobal(globalVar: string) {
-            if (window[globalVar]) {
+            if (window[globalVar] != null) {
                 var result = window[globalVar];
                 delete window[globalVar];
                 return result;

diff --git a/Scripts/csr-editor.js b/Scripts/csr-editor.js
@@ -1164,7 +1164,7 @@ var CSREditor;
                 var properties = webpart.get_properties();
                 context.load(properties);
                 context.executeQueryAsync(function () {
-                    window["g_Cisar_JSLink"] = properties.get_item("JSLink").toLowerCase();
+                    window["g_Cisar_JSLink"] = (properties.get_item("JSLink") || "").toLowerCase();
                 }, function () {
                     window["g_Cisar_JSLink"] = 'error';
                 });
@@ -1264,7 +1264,7 @@ var CSREditor;
                 var properties = webpart.get_properties();
                 context.load(properties);
                 context.executeQueryAsync(function () {
-                    var oldJsLinkString = properties.get_item("JSLink").toLowerCase();
+                    var oldJsLinkString = (properties.get_item("JSLink") || "").toLowerCase();
                     var toCheck = [];
                     if (path.indexOf(_spPageContextInfo.webServerRelativeUrl) == 0) {
                         toCheck.push(['~site', _spPageContextInfo.webServerRelativeUrl]);
@@ -1336,7 +1336,7 @@ var CSREditor;
             return "(" + SPActions.waitForGlobal + ")('" + globalVar + "');";
         };
         SPActions.waitForGlobal = function (globalVar) {
-            if (window[globalVar]) {
+            if (window[globalVar] != null) {
                 var result = window[globalVar];
                 delete window[globalVar];
                 return result;

diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
   "name": "Cisar",
   "homepage_url": "https://github.com/andrei-markeev/cisar",
-	"version": "2.1",
+	"version": "2.1.2",
 	"description": "SharePoint CSR Live Edit",
   "icons": {
     "48": "AppIcon48.png",