You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thank you a lot for your work, it's an amazing library!
It's not an issue for the repo but a note to future user of you library 😄
I use himalaya for some times now and I've made a lot of scrapping things at scale.
If you want to quickly iterate on the JSON, use traverse.
If you have issues with the JSON being incorrect, it's probable because the HTML page is not well formatted and even himalaya can't parse it properly, it may be a really special case or a human mistake. So, for this issue use DOMPurify BEFORE using parse of himalaya.
You'll lose some performance but you'll gain more confort and a proper parsing of your HTML pages.
One more thing, use as much as asynchronous things as possible AND when using traverse, please make a cache and do not use traverse(json) each time, do const cache = traverse(json); instead. (cache.get(....) etc...)
Have fun, this library is really awesome and combined with the right processes, methodologies and other libraries, it's a really life saver!
Thank you @andrejewski for making this library, your hard work is impressive 😉
I'm closing this "issue" immediately! 😅
PS : you should add a way to support financially this library
The text was updated successfully, but these errors were encountered:
Hi,
First of all, thank you a lot for your work, it's an amazing library!
It's not an issue for the repo but a note to future user of you library 😄
I use
himalaya
for some times now and I've made a lot of scrapping things at scale.If you want to quickly iterate on the JSON, use traverse.
If you have issues with the JSON being incorrect, it's probable because the HTML page is not well formatted and even
himalaya
can't parse it properly, it may be a really special case or a human mistake. So, for this issue use DOMPurify BEFORE usingparse
ofhimalaya
.You'll lose some performance but you'll gain more confort and a proper parsing of your HTML pages.
One more thing, use as much as asynchronous things as possible AND when using
traverse
, please make a cache and do not usetraverse(json)
each time, doconst cache = traverse(json);
instead. (cache.get(....)
etc...)Have fun, this library is really awesome and combined with the right processes, methodologies and other libraries, it's a really life saver!
Thank you @andrejewski for making this library, your hard work is impressive 😉
I'm closing this "issue" immediately! 😅
PS : you should add a way to support financially this library
The text was updated successfully, but these errors were encountered: