ci: use shellcheck-py in order to run it on pre-commit.ci (#451)

.pre-commit-config.yaml

@@ -9,8 +9,7 @@ default_language_version:
 
 # https://pre-commit.ci/#configuration
 ci:
-  # TODO: ci: use shellcheck-py to run shellcheck on pre-commit.ci
-  skip: [local-nitpick, autofix-docs, pylint, shellcheck]
+  skip: [local-nitpick, autofix-docs, pylint]
 
 repos:
   - repo: local
@@ -144,8 +143,8 @@ repos:
       - id: bandit
         args: [--ini, setup.cfg]
         exclude: tests/
-  - repo: https://github.com/jumanjihouse/pre-commit-hooks
-    rev: 2.1.5
+  - repo: https://github.com/shellcheck-py/shellcheck-py
+    rev: v0.8.0.3
     hooks:
       - id: shellcheck
   - repo: https://github.com/openstack/bashate

src/nitpick/resources/shell/shellcheck.toml

@@ -7,8 +7,10 @@ url = "https://github.com/koalaman/shellcheck"
 enabled = true
 
 [[".pre-commit-config.yaml".repos]]
-repo = "https://github.com/jumanjihouse/pre-commit-hooks"
+# This repo installs the "shellcheck" executable, and this is needed in order to run it on https://pre-commit.ci.
+# The previous hook I used (https://github.com/jumanjihouse/pre-commit-hooks) didn't do that, and fails with the error
+# "This check needs shellcheck from https://github.com/koalaman/shellcheck"
+repo = "https://github.com/shellcheck-py/shellcheck-py"
 
 [[".pre-commit-config.yaml".repos.hooks]]
-# https://github.com/jumanjihouse/pre-commit-hooks#shellcheck
 id = "shellcheck"

tests/test_builtin/shell/shellcheck/.pre-commit-config.yaml

@@ -1,4 +1,4 @@
 repos:
-  - repo: https://github.com/jumanjihouse/pre-commit-hooks
+  - repo: https://github.com/shellcheck-py/shellcheck-py
     hooks:
       - id: shellcheck