Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document attempt to keep only tomlkit #444

Merged
merged 4 commits into from
Jan 15, 2022
Merged

Conversation

andreoliwa
Copy link
Owner

Proposed changes

Nothing really changed in this pull request.
I'm documenting the failed attempt.

  1. https://github.com/sdispater/tomlkit preserves comments in the TOML file.
  2. uiri/toml looks abandoned: Please add a co-maintainer uiri/toml#361
  3. I also briefly tried using https://github.com/hukkin/tomli; but it's read only, it doesn't write TOML. I would still need to use tomlkit or uiri/toml to write the file.
  4. I couldn't easily remove empty tables from the output of tomlkit.dumps(). I raised the issue on The dumps() function renders empty tables when a dict is the data argument python-poetry/tomlkit#166

@andreoliwa andreoliwa merged commit 561328c into develop Jan 15, 2022
@andreoliwa andreoliwa deleted the use-only-tomlkit branch January 15, 2022 20:25
@github-actions
Copy link

🎉 This PR is included in version 0.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Feature/fix is released label Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Feature/fix is released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant