Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect notch paddings on iPhone 12 #45

Closed
Andrew67 opened this issue Jul 7, 2021 · 1 comment
Closed

Incorrect notch paddings on iPhone 12 #45

Andrew67 opened this issue Jul 7, 2021 · 1 comment
Labels
bug

Comments

@Andrew67
Copy link
Owner

Andrew67 commented Jul 7, 2021

iPhone 12 models introduced brand new screen sizes.
OnsenUI uses the screen size to determine whether a phone is iPhone X or newer, to apply hard-coded padding (as opposed to the new env()).
Short-term fix: newer OnsenUI release contains iPhone 12 sizes.
Long-term fix: switch to CSS that uses env().
@Andrew67 Andrew67 added the bug label Jul 7, 2021
@Andrew67
Copy link
Owner Author

Updated to newer OnsenUI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Andrew67