Incorrect Array sortBy order

[Mottie]

Once again, thank you for an awesome library!

First off, the sort tests appear to be failing, but I can't tell if it is a problem with the sortBy function.

So, even with the default sort order & ignore case set to false:

Array.AlphanumericSortOrder = "AÁÀÂÃĄBCĆČÇDĎÐEÉÈĚÊËĘFGĞHıIÍÌİÎÏJKLŁMNŃŇÑOÓÒÔPQRŘSŚŠŞTŤUÚÙŮÛÜVWXYÝZŹŻŽÞÆŒØÕÅÄö";
Array.AlphanumericSortIgnoreCase = false;

If I sort an identical sort order string, I get this result:

"AÁÀÂÃĄBCĆČÇDĎÐEÉÈĚÊËĘFGĞHıIÍÌİÎÏJKLŁMNŃŇÑOÓÒÔPQRŘSŚŠŞTŤUÚÙŮÛÜVWXYÝZŹŻŽÞÆŒØÕÅÄö".split("").sortBy().join("");

// result
// "AÀÄÂÁÃBCÇDÅÐEÉÈÊËFGHIÏÍÎÌJKLMNOÔÕÒÓPQRSTUWXYØÚVÑÜÛÙÝZÞÆöĄĆČĎĘĚĞİıŁŃŇŒŘŚŞŠŤŮŹŻŽ"

And here is a demo I was using for testing.

[andrewplummer]

Tests appear passing to me... maybe this is a locale issue?
Can you let me know your exact environment and locale?

[Mottie]

Hi!

I'm on a Windows 8 Pro x64 machine with the region set to United States.

Here are screen shots of the errors I'm seeing on that page:

Chrome 30.0.1599.101 m

Firefox 25.0

[andrewplummer]

Interesting........ can you clear your cache and try again??

[Mottie]

Hmm, well, now the demo seems to be working properly, so I'll go ahead and close this issue. Thanks!

[andrewplummer]

Looks like I need to put a cache killer in the iframe URL probably... I'll make a note to do that in the future!
Thanks!

[Mottie]

I just cleared my browser cache (Chrome) and reran those tests and I'm still seeing the array error, but not the date one.

[andrewplummer]

ok kind of a pain, but can you clone the repo and run test/default.html?
I don't think you'll be able to run it via file:/// so if you have some kind of server set up that would be ideal.

[Mottie]

I had to run it in Firefox and load jQuery using http:// instead of // but it worked and showed these errors:

[andrewplummer]

Very interesting... what's the version of FF?

[Mottie]

The latest v25.0

[andrewplummer]

ok I'll have a look later on a vbox... thanks again!

[Mottie]

Hmm, ok I was wrong. The sort is still incorrect.

I updated the demo to only show one comparison... the result should match the sort string.

We start with this sorted string:

AÁÀÂÃĄBCĆČÇDĎÐEÉÈĚÊËĘFGĞHıIÍÌİÎÏJKLŁMNŃŇÑOÓÒÔPQRŘSŚŠŞTŤUÚÙŮÛÜVWXYÝZŹŻŽÞÆŒØÕÅÄö

and should end with the same result, but instead get this:

ABCDEFGHIİJKLMNOPQRSTUVWXYZÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕöØÙÚÛÜÝÞĄĆČĎĘĚĞıŁŃŇŒŘŚŞŠŤŮŹŻŽ

[andrewplummer]

Hi, I'm really sorry to take so long to respond here!
This got put on the back burner and I never got to it :(

Please have a look here: http://sugarjs.com/arrays#sorting at the second to last paragraph.

Basically you'll have to do a few modifications to achieve correct sort order for Scandinavian languages. You have to turn off the default sort equivalents. For Scandinavian languages only a subset need to be disabled but this is the easiest way:

Array.AlphanumericSortEquivalents = {};

Doing this will allow Array.AlphanumericSortOrder to be respected without any overriding.
I've updated the demo to do this so that it works for you:

http://jsfiddle.net/tBHqG/3/

One more thing though is that the string you passed in for AlphanumericSortOrder only has upper-case characters even though you have IgnoreCase on, so I disabled that to use the defaults which have both upper and lower case.

[Mottie]

Awesome! Thanks!

[Mottie]

Oops, I'm still seeing failing tests in both Chrome & Firefox.

Chrome 34.0.1847.131 m (Windows 8 x64)

Firefox 28.0 (Windows 8 x64)

[andrewplummer]

After looking into it, two were badly formed tests that have since been fixed, and one was a change caused by a Chrome update. This has also been accounted for in the current edge version.
I went ahead and fixed it on the site.

Thanks!

[Mottie]

Awesome work!