Make Links Clickable #380
Merged
Make Links Clickable #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| function linkify(text) { | ||
| if (text) { | ||
| text = text.replace(/(^|[^\/])(www\.[^\.]+\.[\S]+(\b|$))/gi, '$1http://$2'); |
There was a problem hiding this comment.
I think false positives are very annoying. I'd rather have zero false positives and not support, e.g. 'www.example.com'. So I think we should require the protocol in order to make links blue. This makes the detection regex much simpler, and lets us do it with only 1 regex.
There was a problem hiding this comment.
So you're saying you only want to link a fully-formed domain of something like 'http://wowihadtotypehttp.com'?
There was a problem hiding this comment.
Heh. It would seem that that's what Github does.
malakada
force-pushed
the
feature/linkify_urls
branch
from
11b2b79
to
5c6018b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #328.