Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty bulletin files are being downloaded #26

Closed
spykelionel opened this issue Oct 2, 2022 · 6 comments · Fixed by #59
Closed

Empty bulletin files are being downloaded #26

spykelionel opened this issue Oct 2, 2022 · 6 comments · Fixed by #59
Assignees
Labels
hacktoberfest help wanted Extra attention is needed

Comments

@spykelionel
Copy link

spykelionel commented Oct 2, 2022

bulletin-medical

Try to download a bulletin, downloads an empty file. A proper message should be displayed for a blank bulletin.
tableDownload.csv

@AndrGab AndrGab added help wanted Extra attention is needed hacktoberfest labels Oct 2, 2022
@dshubhadeep
Copy link
Contributor

Hi @AndrGab
Could you assign this to me ?

@AndrGab
Copy link
Owner

AndrGab commented Oct 2, 2022

Sure.. happy to have you here

@dshubhadeep
Copy link
Contributor

dshubhadeep commented Oct 3, 2022

Looked into the issue, according to mui documentation there is a download key in the options which takes either string or boolean value.

So based on size of the rows array, we could set the download key in options object in Bulletin.js as -

const options = {
//...
download: rows.length ? true : 'disabled',
// ... 
}

Please let me know if you are fine with this approach.

@AndrGab
Copy link
Owner

AndrGab commented Oct 4, 2022

nice, I'm fine with that

@AndrGab
Copy link
Owner

AndrGab commented Oct 5, 2022

hi @dshubhadeep
how are u you?
Can you complete the task?
thank you very much

@dshubhadeep
Copy link
Contributor

@AndrGab apologies for the delay
I've created the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants