Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated GitHub actions usage #355

Closed
TWiStErRob opened this issue Oct 18, 2022 · 11 comments
Closed

Deprecated GitHub actions usage #355

TWiStErRob opened this issue Oct 18, 2022 · 11 comments

Comments

@TWiStErRob
Copy link

TWiStErRob commented Oct 18, 2022

Warning: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Example: https://github.com/TWiStErRob/glide-support/actions/runs/3275044365/jobs/5389377582#step:3:710

Similar fix: https://github.com/actions/checkout/pull/962/files#diff-321508dc4e9600826d25995a75796331f7015f0faeaea651daf659bf3e8a98f6L46

@TWiStErRob
Copy link
Author

Will be solved by #347, because you only use setOutput.

@ViliusSutkus89
Copy link
Collaborator

Thanks for bringing this up. Kind of an easy fix. Let's see if the warnings go away

@TWiStErRob
Copy link
Author

TWiStErRob commented Oct 18, 2022

Confirmed fixed! Re-ran the the job I quoted above on the same commit.

      - name: Set up Android SDK.
        uses: android-actions/setup-android@v2

Before:
https://github.com/TWiStErRob/glide-support/actions/runs/3275044365/jobs/5389377582#step:3:710
image

After:
https://github.com/TWiStErRob/glide-support/actions/runs/3275044365/jobs/5393688733#step:3:708
image

Thanks for the amazing turnaround.

@ViliusSutkus89
Copy link
Collaborator

No need to thank me, that warning would have turned into an error eventually. Now I need to find 20+ different places in other projects where I use set-output manually

@TWiStErRob
Copy link
Author

Not much: https://github.com/search?q=user%3AViliusSutkus89+set-output&type=code

Example that might help (if you have non-trivial echo): TWiStErRob/net.twisterrob.sun#156

@kyhule
Copy link

kyhule commented Feb 23, 2023

Should I be surprised to still see this error on v2.0.2?
CleanShot 2023-02-22 at 17 07 03@2x

@TWiStErRob
Copy link
Author

Weird the only usage is here:
https://github.com/android-actions/setup-android/blame/main/src/main.ts#L184
And that's still a valid usage, because the actions/core dependency is 1.10.0, bumped by #347

@ViliusSutkus89 is it possible you didn't do npm install at one point when you rebuild the dist?

@TWiStErRob
Copy link
Author

@TWiStErRob
Copy link
Author

@kyhule 2.0.2 is really old, the fix only exists in 2.0.10:
https://github.com/android-actions/setup-android/tags

@kyhule
Copy link

kyhule commented Feb 23, 2023

@TWiStErRob Ah sorry about that. This is the first time using GitHub actions. I was using v2.0.2 because that is the version listed as the latest on the actions marketplace. I'll upgrade to v2.0.10 today!
Screenshot_20230223-080443.png

@TWiStErRob
Copy link
Author

TWiStErRob commented Feb 23, 2023

I recommend you just use @v2, then this is not a problem, you get free patches. @ViliusSutkus89 any idea what's missing for recent versions to show up at https://github.com/marketplace/actions/setup-android-sdk-tools?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants