-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] libz.a for armeabi-v7a is missing symbols #1391
Comments
hmm. i wrote this in the Android.bp:
i've just done an upstream update anyway so i'll have a look and see if that's actually/still true. (things might get a bit interesting if non-neon is just not supported, but we can always hack in some stubs.) works for me locally, but iirc i need to let treehugger actually do an NDK build to hit the non-neon case anyway: https://android-review.googlesource.com/c/platform/external/zlib/+/1519998 |
okay, the obvious "let's just build it" failed:
...but playing with the |
Prebuilt updated in |
Context: https://github.com/android/ndk/wiki/Changelog-r22#r22b Context: android/ndk#1427 Upstream changes: * [Issue 1377][0]: Fix Clang backend crash in register scavenging. * [Issue 1388][1]: Fixed LLVM's incorrect conversion to list files for long command lines on Windows. * [Issue 1391][2]: Fixed missing symbols from libz.a. * [Issue 1427][3]: Fixed Clang auto-detection for CMake 3.19 and older for Windows. Fix for issue 1427 above allows us to remove the older Android cmake toolchain file we've been using to work around the bug on Windows platforms. [0]: android/ndk#1377 [1]: android/ndk#1388 [2]: android/ndk#1391 [3]: android/ndk#1427
Context: https://github.com/android/ndk/wiki/Changelog-r22#r22b Context: android/ndk#1427 Upstream changes: * [Issue 1377][0]: Fix Clang backend crash in register scavenging. * [Issue 1388][1]: Fixed LLVM's incorrect conversion to list files for long command lines on Windows. * [Issue 1391][2]: Fixed missing symbols from `libz.a`. * [Issue 1427][3]: Fixed Clang auto-detection for CMake 3.19 and older for Windows. The fix for issue 1427 above allows us to remove the older Android cmake toolchain file we've been using (accc846) to work around the bug on Windows platforms. [0]: android/ndk#1377 [1]: android/ndk#1388 [2]: android/ndk#1391 [3]: android/ndk#1427
Bug: android/ndk#1391 Test: treehugger Test: ./build/soong/scripts/build-ndk-prebuilts.sh Change-Id: I4e2f7836883cbad8cb533561e73cd7afcaf75ec4
Using NDK r22-beta1 (22.0.6917172-beta1) on macOS with
ndk-build
to build static binaries.When statically linking
libz.a
in 32 bit ARM code, the linker will complain with the following error:Using
readelf
to print out symbols of alllibz.a
for arm 32, it seems alllibz.a
archives are missingcpu_features.o
, causing the following symbols to be undefined:This issue does not happen on any other arch.
The text was updated successfully, but these errors were encountered: