Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLVM handling of long windows command lines incorrect #1388

Closed
DanAlbert opened this issue Dec 4, 2020 · 2 comments
Closed

LLVM handling of long windows command lines incorrect #1388

DanAlbert opened this issue Dec 4, 2020 · 2 comments
Assignees
@stephenhines
Labels
bug
Projects
r21e r23 LLVM r22b

Comments

@DanAlbert
Copy link
Member

Need to backport https://reviews.llvm.org/D83772
@DanAlbert DanAlbert added the bug label Dec 4, 2020
@DanAlbert DanAlbert added this to Triaged in r23 via automation Dec 4, 2020
@DanAlbert DanAlbert added this to Triaged in r21e via automation Dec 4, 2020
@DanAlbert DanAlbert added this to Triaged in r22 via automation Dec 4, 2020
@DanAlbert DanAlbert removed this from Triaged in r22 Dec 4, 2020
@DanAlbert DanAlbert added this to Awaiting triage in LLVM via automation Dec 4, 2020
@DanAlbert DanAlbert added this to Triaged in r22b via automation Dec 4, 2020
@DanAlbert DanAlbert moved this from Triaged to Needs prebuilt update in r22b Dec 4, 2020
@DanAlbert DanAlbert moved this from Triaged to Needs prebuilt update in r23 Dec 4, 2020
@DanAlbert DanAlbert moved this from Triaged to Needs prebuilt update in r21e Dec 4, 2020
@DanAlbert DanAlbert moved this from Awaiting triage to Awaiting update in LLVM Dec 4, 2020
@stephenhines
Copy link
Collaborator

https://android-review.googlesource.com/c/toolchain/llvm-project/+/1518414 is the cherry-pick for r21e.

We should also mention that this is related to the request from issue #1386 .

@DanAlbert DanAlbert moved this from Needs prebuilt update to Needs cherry-pick in r21e Dec 11, 2020
@DanAlbert DanAlbert moved this from Needs cherry-pick to Merged in r21e Jan 21, 2021
@hhb
Copy link
Collaborator

hhb commented Feb 19, 2021

https://android-review.googlesource.com/c/platform/prebuilts/clang/host/windows-x86/+/1595520 is the cherry-pick for 22b

@hhb hhb moved this from Needs prebuilt update to Merged in r22b Feb 22, 2021
@DanAlbert DanAlbert moved this from Needs prebuilt update to Merged in r23 Feb 25, 2021
@DanAlbert DanAlbert moved this from Awaiting update to Prebuilts submitted in LLVM Feb 25, 2021
grendello added a commit to grendello/xamarin-android that referenced this issue Mar 25, 2021
@grendello
Update NDK to r22b
d0ce657 
Context: https://github.com/android/ndk/wiki/Changelog-r22#r22b
Context: android/ndk#1427

Upstream changes:

  * [Issue 1377][0]: Fix Clang backend crash in register scavenging.
  * [Issue 1388][1]: Fixed LLVM's incorrect conversion to list files for long command lines on Windows.
  * [Issue 1391][2]: Fixed missing symbols from libz.a.
  * [Issue 1427][3]: Fixed Clang auto-detection for CMake 3.19 and older for Windows.

Fix for issue 1427 above allows us to remove the older Android cmake
toolchain file we've been using to work around the bug on Windows
platforms.

[0]: android/ndk#1377
[1]: android/ndk#1388
[2]: android/ndk#1391
[3]: android/ndk#1427
@grendello grendello mentioned this issue Mar 25, 2021
Merged
jonpryor pushed a commit to dotnet/android that referenced this issue Mar 26, 2021
@grendello
Bump to NDK r22b (#5780)
cc3d123 
Context: https://github.com/android/ndk/wiki/Changelog-r22#r22b
Context: android/ndk#1427

Upstream changes:

  * [Issue 1377][0]: Fix Clang backend crash in register scavenging.
  * [Issue 1388][1]: Fixed LLVM's incorrect conversion to list files
    for long command lines on Windows.
  * [Issue 1391][2]: Fixed missing symbols from `libz.a`.
  * [Issue 1427][3]: Fixed Clang auto-detection for CMake 3.19 and
    older for Windows.

The fix for issue 1427 above allows us to remove the older Android
cmake toolchain file we've been using (accc846) to work around the
bug on Windows platforms.

[0]: android/ndk#1377
[1]: android/ndk#1388
[2]: android/ndk#1391
[3]: android/ndk#1427
msatranjr pushed a commit to msft-mirror-aosp/platform.prebuilts.clang.host.darwin-x86 that referenced this issue Feb 8, 2023
@stephenhines
Update prebuilt Clang to r365631c3 (9.0.9).
88d6fae 
clang 9.0.9 (based on r365631c3) from build 7019983.

Bug: android/ndk#1388
Test: N/A
Change-Id: Ic7cab7cbf24b2a54fc810a0bb5a683185abfcce3
(cherry picked from commit 109f6b1c0ff3c580a82e6a4c8193330e6b85cc43)
msatranjr pushed a commit to msft-mirror-aosp/platform.prebuilts.clang.host.darwin-x86 that referenced this issue Feb 8, 2023
@stephenhines
Update prebuilt Clang to r399163b1 (11.0.5).
48c960e 
clang 11.0.5 (based on r399163b1) from build 7155654.

Bug: android/ndk#1388
Test: N/A
Change-Id: Ibf92249fc293f7e211e6f49db892169c89b10d7f
(cherry picked from commit d06f99c2077eda0cff2f478dfea10aca4a48bdae)
msatranjr pushed a commit to msft-mirror-aosp/platform.prebuilts.clang.host.linux-x86 that referenced this issue Feb 8, 2023
@stephenhines
Update prebuilt Clang to r365631c3 (9.0.9).
c027a23 
clang 9.0.9 (based on r365631c3) from build 7019983.

Bug: android/ndk#1388
Test: N/A
Change-Id: I20a3cc71ab56af309ec379059d7442032fe19369
(cherry picked from commit fb2f286d68afe133e997528309e9d2f4cae93cb7)
msatranjr pushed a commit to msft-mirror-aosp/platform.prebuilts.clang.host.linux-x86 that referenced this issue Feb 8, 2023
@stephenhines
Update prebuilt Clang to r365631c3 (9.0.9).
bd5b946 
clang 9.0.9 (based on r365631c3) from build 7019983.

Bug: android/ndk#1388
Test: N/A
Change-Id: I20a3cc71ab56af309ec379059d7442032fe19369
(cherry picked from commit fb2f286d68afe133e997528309e9d2f4cae93cb7)
msatranjr pushed a commit to msft-mirror-aosp/platform.prebuilts.clang.host.darwin-x86 that referenced this issue Feb 8, 2023
@stephenhines
Update prebuilt Clang to r365631c3 (9.0.9).
2e876a9 
clang 9.0.9 (based on r365631c3) from build 7019983.

Bug: android/ndk#1388
Test: N/A
Change-Id: Ic7cab7cbf24b2a54fc810a0bb5a683185abfcce3
(cherry picked from commit 109f6b1c0ff3c580a82e6a4c8193330e6b85cc43)
msatranjr pushed a commit to msft-mirror-aosp/platform.prebuilts.clang.host.linux-x86 that referenced this issue Feb 8, 2023
@stephenhines
Update prebuilt Clang to r399163b1 (11.0.5).
c0c1ea5 
clang 11.0.5 (based on r399163b1) from build 7155654.

Bug: android/ndk#1388
Test: N/A
Change-Id: I271b70b258e8a5563cc8babe639497a052a4b7d5
(cherry picked from commit 93f84143ce566646974537bcccfa44c28b1828d3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenhines stephenhines

Labels
bug
Projects
LLVM
  
Prebuilts submitted
r21e
  
Merged
r22b
  
Merged
r23
  
Merged
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DanAlbert @hhb @stephenhines