-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libshaderc sources in NDK r.17 outdated #704
Comments
Thanks for refiling this from stack overflow, Alex. Looks like we do have the updates in master. @dneto0: how risky would it be to merge all the updates in the master-ndk branch into the r17 branch for a hotfix? r17 has already released to stable, so if there's much risk we can just close this as fixed in r18 and move the bug over to the samples to suppress the warning for now. |
I think the only risk is in the interaction with the Vulkan loader and layers component, which also uses the SPIRV-Tools.
|
Okay, I'll pull updates for all of those into r17b. |
Description
Vulcan API samples building fails with NDK r.17. The answer explains the problem. Actually, the fix for Clang 6.0 was ready 4 months ago, but sources/third_party/shaderc has not been updated.
Environment Details
The text was updated successfully, but these errors were encountered: