Skip to content
This repository has been archived by the owner on Jan 23, 2021. It is now read-only.

Logout icon instead of action menu with only one item #51

Closed
piotrek1543 opened this issue Nov 8, 2015 · 8 comments
Closed

Logout icon instead of action menu with only one item #51

piotrek1543 opened this issue Nov 8, 2015 · 8 comments

Comments

@piotrek1543
Copy link
Contributor

Hi,

I would like to suggest you to instead of using exisiting action menu with logout item try to implement nice -looking button in this place. I think it might improve a little an user experience of this app.

What do you think guys about this idea?

Cheers

@keyboardsurfer
Copy link
Member

Logging out is not one of the flows that happens a lot within the app.
This is why it's an action that requires two taps.
I agree, that the menu button should have a different color to match the style of the toolbar.

@piotrek1543
Copy link
Contributor Author

To make my issue description more clear, I really like an idea used at first screen of this app:
github.com/kyleduo/SwitchButton/

Thanks for comment. Now I can close an issue.

@keyboardsurfer
Copy link
Member

I don't think that a switch in the toolbar is going to make things more clear.
Or is there something I'm missing out in the screenshot?

@piotrek1543
Copy link
Contributor Author

@keyboardsurfer, switch? I'm thinking about a button on the right side of a toolbar like you can see on the first screen with Github or K logo. Clicking on this will automatically log out user.
Instead of two clicks than would be only one :-)
But like you said, logging out of app is not a key feature, so it could take more clicks.

@keyboardsurfer
Copy link
Member

Ok. I see the point now.
Logging out will clear the preferences and remove all scores.
Having a user accidentally press that is not the right approach.

I'll change the menu button's color to white nonetheless.

@piotrek1543
Copy link
Contributor Author

@keyboardsurfer, heh... maybe it's time to implement High Score board. Having this feature would fix this problem: click on "L" logout button will save user name and score :-)

Ok, now I close the issue as 'not to resolved'.

@keyboardsurfer
Copy link
Member

API level 21+ now has a menu button color that matches the title text color. Released with a0c8b2f.

@piotrek1543
Copy link
Contributor Author

@keyboardsurfer , good to know. Thanks :-) I will check it later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants