Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse of the ViewHolder class name #27

Open
kroikie opened this issue Jul 29, 2015 · 1 comment
Open

Reuse of the ViewHolder class name #27

kroikie opened this issue Jul 29, 2015 · 1 comment
Labels
migrated googlesamples Issue migrated from old repo location (googlesamples/)

Comments

@kroikie
Copy link

kroikie commented Jul 29, 2015

Use CostomViewHolder instead of ViewHolder for custom View Holder.
https://github.com/googlesamples/android-RecyclerView/blob/master/Application/src/main/java/com/example/android/recyclerview/CustomAdapter.java#L39

@PaulRashidi
Copy link

I made this suggestion to Arthur in the office the other day. I was referencing snippets of the sample when writing something up and the reuse of the ViewHolder class name doubled the explanation length. Referencing CustomViewHolder as a class would have been much more concise and I believe it makes the snippets more readable when viewed in isolation. Just a suggestion.

@codingjeremy codingjeremy transferred this issue from googlearchive/android-RecyclerView Sep 16, 2019
@codingjeremy codingjeremy added the migrated googlesamples Issue migrated from old repo location (googlesamples/) label Sep 16, 2019
@chrisbanes chrisbanes removed their assignment Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migrated googlesamples Issue migrated from old repo location (googlesamples/)
Projects
None yet
Development

No branches or pull requests

4 participants