Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range of validity #15

Open
andrsd opened this issue Sep 3, 2022 · 0 comments
Open

Range of validity #15

andrsd opened this issue Sep 3, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@andrsd
Copy link
Owner

andrsd commented Sep 3, 2022 •
edited
Loading

Add checks for range of validity.

Idea:

  • an abstract virtual method (so that it has to be implemented) that return true if given state point is valid, false otherwise
  • then in the API (p_T, u_v), if the above method returns false, we would throw std::domain_error.
  • ❓: will need several validation methods, since mu, k and EOS can all have different ranges
@andrsd andrsd added the enhancement New feature or request label Sep 3, 2022
@andrsd andrsd self-assigned this Sep 3, 2022
@andrsd andrsd removed their assignment Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrsd