npapi.h attempts to use MOZ_PLATFORM_MAEMO without checking first if it is defined

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Include npapi.h in bare bones plugin
2. Try to build (defining XP_UNIX and MOZ_X11
3. Failure

What is the expected output? What do you see instead?
A successful build without the MAEMO enums defined.

What operating system are you compiling on?
Ubuntu 10.04

Attached is a patch to first check if the macro is defined before comparing 
it's value.

Original issue reported on code.google.com by robot...@chromium.org on 15 Jul 2011 at 8:39

Attachments:

• 0001-Check-if-MOZ_PLATFORM_MAEMO-is-defined-before-checki.patch

[GoogleCodeExporter]

Hrm, Josh, do you remember why you took those back out? We fixed this in
http://code.google.com/p/npapi-headers/source/detail?r=21
but then you changed it back in
http://code.google.com/p/npapi-headers/source/detail?r=31

Original comment by stuart.morgan on 19 Jul 2011 at 9:01

[GoogleCodeExporter]

I'll fix this within the next week or so.

Out of curiosity, what's your toolchain, and what's the exact error?

Original comment by stuart.morgan on 22 Sep 2011 at 3:21

[GoogleCodeExporter]

I'm fine with fixing this. Patch looks good to me so long as all un-checked 
usages are covered.

Original comment by josh....@gmail.com on 22 Sep 2011 at 3:21

[GoogleCodeExporter]

Landed a fix as r14; sorry for the delay.

Original comment by stuart.morgan on 13 Oct 2011 at 8:34

• Changed state: Fixed