Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments are not unmarshalled #23

Closed
ifosch opened this issue Jul 2, 2016 · 1 comment · Fixed by #24
Closed

Comments are not unmarshalled #23

ifosch opened this issue Jul 2, 2016 · 1 comment · Fixed by #24

Comments

@ifosch
Copy link
Contributor

ifosch commented Jul 2, 2016

Using go-jira for a CLI, I found that comments are not being unmarshalled for any Issue.
I did the following try on your code, and got issue_test doesn't pass. In https://github.com/andygrunwald/go-jira/blob/master/issue_test.go#L140, I added:

if len(issue.Fields.Comments) != 1 {
  t.Error("Expected one comment, %v found", len(issue.Fields.Comments))
}

I'm not very experienced in Go programming and even most not sure of understanding JSON Unmarshalling anyway, so I might be wrong. I might like to contribute a fix for this, but I'm uncertain about this actually being a bug, or how to diagnose and fix... I also found another issue, trying to see the response body, but this should probably be another issue.

I apologize if this is not the correct way to contribute, or help; I'm just trying to use this :)

@andygrunwald
Copy link
Owner

Thanks. Was fixed in #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants