Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Period table flexibility #64

Closed
andykrause opened this issue May 20, 2020 · 1 comment
Closed

Period table flexibility #64

andykrause opened this issue May 20, 2020 · 1 comment
Assignees
@andykrause
Labels
enhancement

Comments

@andykrause
Copy link
Owner

Currently, the period_table attribute is only designed to work with calendar based period definitions. As #25 suggest, there could be use cases for arbitrary periods or data-defined ones. The period table creation needs upgrading.
@andykrause andykrause self-assigned this May 20, 2020
@andykrause
Copy link
Owner Author

Schema for this should be simple:

  • start_date
  • end_date
  • period (ascending integer)
  • name (optional)

andykrause added a commit that referenced this issue May 21, 2020
@andykrause
Standardizing Period Tables #64
5b6260a 
- Created a standardized and more portable period_table
- Refactored a bit of dateToPeriod() to more easy accomplish future additions
- Updated tests
- Updated vignettes
- Updated news.md for future release
andykrause added a commit that referenced this issue May 21, 2020
@andykrause
Merge pull request #65 from andykrause/periodtable_#64
74a5df5 
Periodtable #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andykrause andykrause

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andykrause