Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for azurefile.go #5

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Conversation

Masquerade0097
Copy link
Contributor

Fixes #1

Added tests for getFileShareInfo, getStorageAccount under azurefile.go

@Masquerade0097
Copy link
Contributor Author

@andyzhangx Please review.

@@ -18,6 +18,7 @@ package azurefile

import (
"fmt"
"github.com/stretchr/testify/assert"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this line to the bottom:

	"fmt"
	"reflect"
	"testing"

	"github.com/stretchr/testify/assert"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@andyzhangx
Copy link
Member

thanks.
Coverage increased (+3.7%) to 20.694%

@andyzhangx andyzhangx merged commit da56088 into kubernetes-sigs:master Jan 11, 2019
levimm pushed a commit to levimm/azurefile-csi-driver that referenced this pull request Dec 25, 2019
dobsonj pushed a commit to dobsonj/azurefile-csi-driver that referenced this pull request Feb 22, 2022
Bug 2019128: Merge changes from upstream tag v1.7.0 into master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants