Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support credentials_json as option for full-text of client_secrets.json #26

Closed
aaronsteers opened this issue Apr 11, 2023 · 1 comment
Closed

Support credentials_json as option for full-text of client_secrets.json #26

aaronsteers opened this issue Apr 11, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone
v0.3.7

Comments

@aaronsteers
Copy link

aaronsteers commented Apr 11, 2023 •
edited
Loading

In some runtimes, it is not feasible to load a physical client_secrets.json file - for instance in managed or ephemeral environments.

Could we add support for something like credentials_json as a JSON string of the contents of client_secrets.json?

Relevant code snippets:

https://github.com/z3z1ma/target-bigquery/blob/2b771a26ae04ed34e7411b2bb3aa84c80ee9b141/target_bigquery/target.py#L318-L322

https://github.com/z3z1ma/target-bigquery/blob/2b771a26ae04ed34e7411b2bb3aa84c80ee9b141/target_bigquery/core.py#L213-L222

https://github.com/z3z1ma/target-bigquery/blob/2b771a26ae04ed34e7411b2bb3aa84c80ee9b141/target_bigquery/core.py#L578-L584
@daigotanaka daigotanaka added the enhancement New feature or request label Apr 16, 2023
@daigotanaka daigotanaka added this to the v0.3.7 milestone Apr 16, 2023
@daigotanaka
Copy link
Collaborator

Solved by #27 (thx @cjohnhanson!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.3.7
Development

No branches or pull requests
2 participants
@daigotanaka @aaronsteers