Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equippable comparison could be more informative #5348

Open
jl8e opened this issue Apr 24, 2022 · 3 comments
Open

Equippable comparison could be more informative #5348

jl8e opened this issue Apr 24, 2022 · 3 comments
Milestone

Comments

@jl8e
Copy link

jl8e commented Apr 24, 2022

In the item listing, there's the object symbol, a mystery letter (seems to be one of e, h, or occasionally p or f), then its name.

First of all, AFAIK, the mystery letter is explained nowhere. I can deduce what it means, I think. (Equipped, home, carried, and on the floor). 'i' would be a better choice for carried than 'p'.

Secondly, and this is mostly about elvenkind items, which are both armor and shields: I can't tell which is which from the object symbol. I've been playing this game since forever, and still can't tell you which of the various parentheses and brackets are armor and which are shields. Much more useful would be the inventory slot they use. (Yes, they're sorted by slot; the boundaries are not always obvious.)

(Also, until I wrote this, I didn't even realize they were sorted by slot.)

@jl8e
Copy link
Author

jl8e commented Apr 24, 2022

And, while I'm at it, the headers have two light-colored in a row (disenchant and fear), but the columns below keep alternating between light and dark, so headers become the opposite color from their column at that point, and then it happens again at the border of "Bl" and "IH" (no idea what either is), which fixes the columns again.

backwardsEric added a commit to backwardsEric/angband that referenced this issue Apr 25, 2022
backwardsEric added a commit to backwardsEric/angband that referenced this issue Apr 25, 2022
@backwardsEric
Copy link
Contributor

As you guessed, the mystery letter signals the location of the item. 'e' is equipped, 'p' is pack, 'f' is floor, 'h' is home, and 's' is a store other than home. The item attributes have the same ordering as on the resistance part of the character sheet (but are presented from left to right rather than from top to bottom in three columns) so "Bl" is the blessed melee flag and "IH" is the impaired hit point recovery curse.

backwardsEric added a commit to backwardsEric/angband that referenced this issue Apr 28, 2022
@NickMcConnell NickMcConnell added this to the Triage milestone May 6, 2022
NickMcConnell pushed a commit that referenced this issue May 6, 2022
NickMcConnell pushed a commit that referenced this issue May 6, 2022
NickMcConnell pushed a commit to NickMcConnell/FAangband that referenced this issue May 6, 2022
NickMcConnell pushed a commit to NickMcConnell/FAangband that referenced this issue May 6, 2022
@NickMcConnell
Copy link
Member

Is there anything left to do here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants