Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give feature_0 and feature_1 files more informative names #745

Closed
ngreenwald opened this issue Oct 4, 2022 · 1 comment · Fixed by #786
Closed

Give feature_0 and feature_1 files more informative names #745

ngreenwald opened this issue Oct 4, 2022 · 1 comment · Fixed by #786
Assignees
@alex-l-kong
Labels
enhancement New feature or request

Comments

@ngreenwald
Copy link
Member

Is your feature request related to a problem? Please describe.
The current pipeline produces tifs that are named feature_0 and feature_1, which are not informative

Describe the solution you'd like
We should rename these with more informative names, reflecting the fact that they are cell and nuclear segmentation
@ngreenwald ngreenwald added the enhancement New feature or request label Oct 4, 2022
@alex-l-kong
Copy link
Contributor

Per lab meeting we agreed to rename feature_0 to whole_cell and feature_1 to nuclear.

@alex-l-kong alex-l-kong mentioned this issue Oct 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-l-kong alex-l-kong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename _feature_0 to _whole_cell and _feature_1 to _nuclear angelolab/ark-analysis
2 participants
@ngreenwald @alex-l-kong