Docker Tags in line with ark-analysis Version #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ngreenwald The readthedocs issue is being fixed in #650. The docker does get tagged with |
ngreenwald
requested changes
Aug 22, 2022
.travis.yml
Outdated
| - docker push "$TRAVIS_REPO_SLUG" | ||
| - echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin | ||
| - docker build -t "$TRAVIS_REPO_SLUG":"$TRAVIS_TAG" . 1> /dev/null | ||
| # Tag the image with a version like v0.3.2, and create another tag for latest |
There was a problem hiding this comment.
This comment should be updated I think
Dockerfile
Outdated
| @@ -5,6 +5,10 @@ RUN apt-get update | |||
|
|
|||
| # install dependencies needed for setting up R | |||
| RUN apt-get install -y lsb-release dirmngr gnupg apt-transport-https ca-certificates software-properties-common | |||
| RUN apt-get install -y libharfbuzz-dev libfribidi-dev | |||
|
|
|||
| # RUN apt-get -y build-dep libcurl4-gnutls-dev | |||
There was a problem hiding this comment.
No, I will get rid of that commented bit.
| RUN R -e "install.packages('arrow')" | ||
| RUN R -e "install.packages('data.table')" | ||
| RUN R -e "install.packages('doParallel')" | ||
| RUN R -e "install.packages('foreach')" |
There was a problem hiding this comment.
Did moving the order of R vs python resolve the issues?
There was a problem hiding this comment.
No, however it's a quality of life change. The Docker builds the Dockerfile line by line, and we do not expect the R packages to be changed very often if at all. If Docker does not notice changes based on a line, then it'll skip it. However the Python stuff will always be changing, so it'll cut development build time.
ngreenwald
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #634, #659.
Currently
latestalways points to the most recent build of the docker image, which may not be the current version of the repository. As a best practice we should tag the docker image to the same version of ark-analysis.How did you implement your changes
Adjusted the docker build section of the
.travis.ymlto include the tag, and pushing it properly.Remaining issues
None atm.