-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.8 and Native Apple Silicon Support #650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, just one import question.
@@ -11,7 +11,7 @@ | |||
from matplotlib.colors import ListedColormap | |||
import numpy as np | |||
import pandas as pd | |||
from skimage.draw import circle | |||
from skimage.draw import disk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this import used anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. Will remove it. Should I go through and remove all the other unused import statements throughout Ark?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open an issue, we can do it all at once after the workshop as a cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #649. Closes #504.
How did you implement your changes
Fixed API changes with respect to tifffile, and scikit-image. In addition bumped a few packages up for Apple Silicon compatibility.
Updated rtd requirements as well.
Remaining issues