Python 3.8 and Native Apple Silicon Support #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srivarra
added
dependencies
ngreenwald
requested changes
Aug 25, 2022
| @@ -11,7 +11,7 @@ | |||
| from matplotlib.colors import ListedColormap | |||
| import numpy as np | |||
| import pandas as pd | |||
| from skimage.draw import circle | |||
| from skimage.draw import disk | |||
There was a problem hiding this comment.
Is this import used anywhere?
There was a problem hiding this comment.
Nope. Will remove it. Should I go through and remove all the other unused import statements throughout Ark?
There was a problem hiding this comment.
Open an issue, we can do it all at once after the workshop as a cleanup
ngreenwald
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #649. Closes #504.
How did you implement your changes
Fixed API changes with respect to tifffile, and scikit-image. In addition bumped a few packages up for Apple Silicon compatibility.
Updated rtd requirements as well.
Remaining issues