-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge tern def/plugin selection in the same treeview #63
Comments
@vrubezhny @dgolovin @mickaelistria @maxandersen @pascalleclercq @gamerson @paulvi could you please give me your comment about this issue, because I think it's important to know your opinion about the new UI to select tern defs/plugins. Thank's! |
I've not used Tern so I'm just guessing, but I indeed think that a single treeviewer for those 2 items seem better that 2. Indeed, a user who wants to "hack" is tern configuration would most likely want a single entry point. |
Thank's a lot @mickaelistria for your answer. I will do that. Today we have in the project preferences :
to select JSON Type Definitions (simple JSON) and Tern plugin (javascript which uses JSON Type Definitions) I wil remove Type Definitions entry to merge Plugins+Type Definitions :
If somebody wishes other label than "Plugins", don't hesitate to give me a suggestion. Thank's! |
For your info, I have finished this issue. I have decided to use "Facets" instead of using "Plugins" :
Here a screenshot of the new UI Tern Facet project property to select "Plugins" and "JSON Types Definitions" : You can notice too that there are now icons for each "Plugins" and "JSON Types Definitions" Hope you will like it. |
Looks nice... if you wanted to avoid the word "facets" because that is used On Wed, May 21, 2014 at 3:30 PM, Angelo notifications@github.com wrote:
Greg Amerson |
I'm somehow surprised to see that there is no "JavaScript" top category. |
I prefer using "Facet" instead of using "Extension", because Eclipse user are famliliar with "Facet" (you add some capabilities to your project). But if you prefer "Extension", I will change it.
"JavaScript" top category is ecma5 JSON Type Definition, I would like to avoidd changing the original name.
Tern is the inference Javascript engine which is configured with plugins, JSON Type Definition. AngularJS Eclipse is based on the Tern plugin angular.
Tern IDE UI doesn't depends on JSDT. So you could use tern.java for other editor kind. The project https://github.com/angelozerr/tern.java/tree/master/eclipse/tern.eclipse.ide.jsdt is a bridge between Tern and JSDT : it defines for instance compeltion extension for JSDT with tern. |
I don't have a strong preference for extension over facet... both can work On Wed, May 21, 2014 at 4:18 PM, Angelo notifications@github.com wrote:
Greg Amerson |
Ok thank's @gamerson I will keep "Facets" for the moment. Just for your information, I have the intention to improve this UI with:
|
I agree with @gamerson i think facet is a very different thing than this. This is something you would configure on a tern/javascript facet - it is not a facet itself. |
Ok @maxandersen, we could rename facet to
I would like to avoid using "plugin" because tern provides Tern plugin and JSON Type Definition. My preference is module. I'm waiting for your answer. |
@vrubezhny @dgolovin @mickaelistria @maxandersen @pascalleclercq @gamerson @paulvi are you OK to rename facet to module? |
Personally me - yes, I'm OK with 'module' instead of 'facet'. |
Ok I have created a new issue for that. See #81 I will try to do that this WE. If you don't like 'module', please tell me. |
Ok changes was done (screenshot of wiki too). Now module is used instead of facet. |
Today, we have 2 treeviews for tern definition and tern plugin. I think it should be better to merge those treeview in one treeview.
What do you think about that?
Which names could we use? Tern Plugins? Tern facets? Tern features? Tern capabilities?
The text was updated successfully, but these errors were encountered: