Confusion about Reverse bit operation

[laanwj]

In [10]: claripy.BVV(0x00000001, 32).reversed
Out[10]: <BV32 0x1000000>

I'd have expected <BV32 0x80000000>, reversing the order of bits in a word.

The documentation says that the Reverse operation "Reverses a bit expression."

I understand why the operation does what it does, reverse by byte for an endian flip, but the naming and documentation could use improvement. When I first saw it as output in a symbolic expression I was really confused, "why would this code flip all the bits around".

[ltfish]

I agree that the documentation can use some improvement. Here Reverse is referring to byte-level reversing used in an endianness conversion.

I'm assigning it to @zardus since he is a native speaker.

[salls]

We've been having some discussion concerning the lack of clarity in naming. I guess this is another example we should consider

[zardus]

Thanks for bringing this up. I've added it to the "project" where we're tracking these usability improvements we need to make (https://github.com/angr/angr/projects/1).

[rhelmot]

The official operations appendix now lists .reverse as "endian-reverses a bitvector"