Skip to content
This repository has been archived by the owner on May 18, 2022. It is now read-only.

unicorn engine warning appears even when nobody is trying to use it #82

Open
rhelmot opened this issue Feb 1, 2017 · 0 comments
Open

Comments

@rhelmot
Copy link
Member

rhelmot commented Feb 1, 2017

[15:14:51] [simuvex.plugins.unicorn] | ERROR: You are attempting to use unicorn engine support even though it or the simuvex compatibility layer isn't installed

This is because this unicorn SimEngine runs the cooldown decrement function in the _check_failed callback, regardless of the reason for failure. This should be moved to being called directly from the check function, ONLY when the state option is enabled, perhaps guarded by a few more checks.

Furthermore, we should use this as an opportunity to re-evaluate the need for a callback function at all. IMO it's a bit of a wart.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant