You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 18, 2022. It is now read-only.
[15:14:51] [simuvex.plugins.unicorn] | ERROR: You are attempting to use unicorn engine support even though it or the simuvex compatibility layer isn't installed
This is because this unicorn SimEngine runs the cooldown decrement function in the _check_failed callback, regardless of the reason for failure. This should be moved to being called directly from the check function, ONLY when the state option is enabled, perhaps guarded by a few more checks.
Furthermore, we should use this as an opportunity to re-evaluate the need for a callback function at all. IMO it's a bit of a wart.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
[15:14:51] [simuvex.plugins.unicorn] | ERROR: You are attempting to use unicorn engine support even though it or the simuvex compatibility layer isn't installed
This is because this unicorn SimEngine runs the cooldown decrement function in the
_check_failed
callback, regardless of the reason for failure. This should be moved to being called directly from the check function, ONLY when the state option is enabled, perhaps guarded by a few more checks.Furthermore, we should use this as an opportunity to re-evaluate the need for a callback function at all. IMO it's a bit of a wart.
The text was updated successfully, but these errors were encountered: