fix(eslint-plugin): export require-localize-metadata rule #1469
Conversation
While there are no Angular files in the repository, it helps to prevent the most trivial bugs for now. - Temporarily disable the `@angular-eslint/require-localize-metadata` rule (see angular-eslint/angular-eslint#1469). - Fix `@angular-eslint/template/prefer-self-closing-tags` config.
|
@amikheychik thanks very much for catching this! It looks like something went wrong with the code formatting check (see here). Would you be able to take a look? FYI @JamesHenry let's also add this rule to the all config when appropriate. |
amikheychik
force-pushed
the
fix/require-localize-metadata
branch
2 times, most recently
from
2e421d9
to
8cb29bc
Compare
|
@abaran30 I've updated the formatting, should be good now. I've also added the rule to the |
Prevents the `Definition for rule '@angular-eslint/require-localize-metadata' was not found` ESLint error. Also, fix sorted order for the `prefer-standalone-component` rule.
amikheychik
force-pushed
the
fix/require-localize-metadata
branch
from
8cb29bc
to
492eb23
Compare
Codecov Report
@@ Coverage Diff @@
## main #1469 +/- ##
=======================================
Coverage 89.32% 89.32%
=======================================
Files 162 162
Lines 3044 3045 +1
Branches 515 515
=======================================
+ Hits 2719 2720 +1
Misses 201 201
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thank you @amikheychik! I'm going to check and make sure that it'd be okay to update the all config in this PR. We wouldn't want to surprise users of the all config unexpectedly with this rule on the next release. |
|
@abaran30 the problem is that without this rule in the BTW, this bug is present since v13.2.0 when the rule was introduced. Would you like me to backport it to v13, v14, and v15? |
|
Yeah new rules should always be added to the all config, it’s expected and can’t wait until major releases. I think users wanting to enable all rules all the time is a pretty strange idea personally but the option is there for those that do |
|
@JamesHenry would you publish v15, v14, and v13 patch versions if I backport this patch there? |
Prevents the
Definition for rule '@angular-eslint/require-localize-metadata' was not foundESLint error.Also, fix sorted order for the
prefer-standalone-componentrule.