Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

Make pouchdb-browser dependency more flexible #115

Merged
merged 1 commit into from
Aug 21, 2017

Conversation

alxndrsn
Copy link
Contributor

Fix for #114

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.957% when pulling 9cd9569 on alxndrsn:soft-couch-dependency into 98d8eaa on angular-pouchdb:master.

@alxndrsn
Copy link
Contributor Author

@tlvince we're using angular-pouchdb at https://github.com/medic and would be happy to help maintain.

cc @SCdF @garethbowen

Copy link
Member

@tlvince tlvince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, thanks. Please could you do the same in bower.json and reformat the commit per conventional commits (so that's picked up by semantic-release). This should probably be a chore type, but I'm fine for it to go through as a fix if you're depending on it :)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.957% when pulling f984b26 on alxndrsn:soft-couch-dependency into 98d8eaa on angular-pouchdb:master.

@alxndrsn
Copy link
Contributor Author

I guess fix is more appropriate as it's changing the style of dependency rather than just updating the version number.

Is the new commit message suitable?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.957% when pulling 4691e72 on alxndrsn:soft-couch-dependency into 98d8eaa on angular-pouchdb:master.

@tlvince
Copy link
Member

tlvince commented Aug 21, 2017

lgtm. Thanks!

@tlvince tlvince merged commit 9515ca9 into angular-pouchdb:master Aug 21, 2017
@alxndrsn
Copy link
Contributor Author

👍 Thanks!

@alxndrsn alxndrsn deleted the soft-couch-dependency branch April 23, 2018 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants