feat(sanitization): refactored, fixed and extended sanitization #993 #1014
Conversation
marklagendijk
commented
Apr 23, 2015
marklagendijk
commented
- Added $translateSanitization
- Removed sanitization logic from interpolators, and implemented usage of $translateSanitization
- Changed $translate to use $translateSanitizationProvider for setting the strategy
- Added support for using multiple sanitization strategies, which will be executed as a chain.
- Throw an error when an unknown strategy name is specified. Failing silently would be a security issue.
- Added methods for adding / removing strategies to $translateSanitizationProvider.
|
Thank you. Looks great. It would be great if you could apply some coding styles ( Anyway.. first look promises a great feature. Everything is tested, even the case w/o the ngSanitize module. I'll have a depper look tomorrow I thing.. |
|
I adjusted the formatting settings in WebStorm and reformatted the code. Apart from that I fixed a small bug, and improved the sanitization tests in the interpolators. |
…ar-translate#993 - Added $translateSanitization - Removed sanitization logic from interpolators, and implemented usage of $translateSanitization - Changed $translate to use $translateSanitizationProvider for setting the strategy - Added support for using multiple sanitization strategies, which will be executed as a chain. - Throw an error when an unknown strategy name is specified. Failing silently would be a security issue. - Added methods for adding / removing strategies to $translateSanitizationProvider.
|
@marklagendijk Thank you very much. Landed as 12dbc57 with some fixups (additional info in log for changelog, and a few updates in the code) |
|
@knalli you're welcome. Thanks for the way you helped with designing and reviewing this. I think we made an huge improvement to the security of angular-translate. |
|
Yes, you are absolutely right. That one has long been overdue. |
|
@knalli question: when do you expect to be the new version (2.7.0?), with this feature in it to be released? |
|
@marklagendijk We have currently 1-2 open feedbacks in queue. After this, we are ready. |
