This repository has been archived by the owner on Nov 30, 2018. It is now read-only.
check maptype properties before refresh #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed solution to item that was piggy-backed onto issue #1542. Idea is to check equality on specific properties of options object - then trigger the map refresh. So if your maptype (e.g. cartodb layer) relies on additional properties/functions that are subject to change - but do not require a map refresh, you won't get the flickering effect.
|
is the failed travis check a known issue? I was running into the same thing in my env - before touching any code. |
|
Yeah thats not you I gotta figure out what wrong with the logger on the master branch. |
|
I'll have it patched soon, the problem is index.js in the logger is for node/ browserify/ commonjs only now. |
|
Merge in updates and I think it should pass now. |
Flickering seems to become more evident when you have > 1 layer.
|
LGTM |
nmccready
added a commit
that referenced
this pull request
Oct 8, 2015
check maptype properties before refresh
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution to item that was piggy-backed onto issue #1542 .
Idea is to check equality on specific properties of options object -
then trigger the map refresh.
So if your maptype (e.g. cartodb layer) relies on additional
properties/functions that are subject to change - but do not require a
map refresh, you won't get the flickering effect.