Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(dropdown): Make Auto-Close Dropdowns optional. Fix #2218 #3045

Closed
wants to merge 1 commit into from
Closed

feat(dropdown): Make Auto-Close Dropdowns optional. Fix #2218 #3045

wants to merge 1 commit into from

Conversation

mariocasciaro
Copy link
Contributor

Introduces an auto-close option which - when specified - works as follows:

  • outsideClick - closes the dropdown automatically only when the user clicks any element outside the dropdown.
  • disabled - disables the auto close. You can then control the open/close status of the dropdown manually, by using is-open.

@asafdav
Copy link

asafdav commented Jan 16, 2015

+1

@wesleycho
Copy link
Contributor

@chrisirhc I noticed you mentioned in #2218 about being willing to review a PR if someone implements the feature. This PR looks pretty good to me, but I'd like a second pair of eyes since I'm too tired at the moment.

That this is an optional feature makes this ok IMO.

@karianna karianna added this to the Backlog milestone Mar 25, 2015
@@ -2,3 +2,7 @@
Dropdown is a simple directive which will toggle a dropdown menu on click or programmatically.
You can either use `is-open` to toggle or add inside a `<a dropdown-toggle>` element to toggle it when is clicked.
There is also the `on-toggle(open)` optional expression fired when dropdown changes state.
By default the dropdown will automatically close if any of its elements it's clicked, you can change this behaviour by setting the `auto-close` option as follows:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if any of its elements it's clicked -> if any of its elements is clicked

@chrisirhc
Copy link
Contributor

Great work. I did a review. This looks good. Just a few suggestions.

@mariocasciaro
Copy link
Contributor Author

I'll make the edits as soon as I have 5 minutes. Thanks for reviewing!

@mariocasciaro
Copy link
Contributor Author

@chrisirhc Merged with upstream and addressed all the comments.

@wesleycho
Copy link
Contributor

Can you clean up the history? The merge commit should not be there.

@wesleycho wesleycho modified the milestones: 0.13.0, Backlog Mar 29, 2015
@mariocasciaro
Copy link
Contributor Author

Done (and merged with latest commits)

@wesleycho
Copy link
Contributor

Thanks for the work here, this will make it in 0.13.0!

fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 9, 2015
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
fernando-sendMail pushed a commit to fernando-sendMail/bootstrap that referenced this pull request Jul 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants