Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Carousel slides in wrong order #3764

Closed
ghost opened this issue Jun 5, 2015 · 4 comments
Closed

Carousel slides in wrong order #3764

ghost opened this issue Jun 5, 2015 · 4 comments

Comments

@ghost
Copy link

ghost commented Jun 5, 2015

Hi,

there's a bug in the carousel when the number of slides increases. (ui-bootstrap 0.13.0)
Check this plunker example: http://plnkr.co/SDAVaJIULWhWFS3fWZHu
The indicator selected after page load is wrong. And proceeding through the slides lets the indicator jump rather arbitrary.

Regards
Sven

@rvanbaalen
Copy link
Contributor

Seems like a legit bug. This used to work in 0.12, as we can see here:

http://plnkr.co/edit/ZMN4iocsp6dHvYDfGdTF?p=preview

Thanks for reporting! We will look into this.

@ghost
Copy link
Author

ghost commented Jun 8, 2015

Hey Robin,

maybe I didn't make myself clear enough. There's no dynamic adding/removing of slides involved in this. By "increase" I meant there's a certain number of static slides in the carousel and exceeding this certain number unveils the described bug.

Regards
Sven 

Am 08. Juni 2015 um 04:20 schrieb Robin van Baalen notifications@github.com:

Seems like a legit bug. The question is however, do we support dynamic carousel items using ng-repeat?
I think we should, however the answer to the question defines if this is a bug or an enhancement request.

Reply to this email directly or view it on GitHub.

@intellix
Copy link

intellix commented Jun 9, 2015

I believe this is caused by orderBy:'index' within the carousel.html template. That seems to be what has changed and removing it fixes this

@wesleycho
Copy link
Contributor

This is indeed a strange bug.

I have a fix I am about to open a PR for.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants