Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(timepicker): add accessibility improvements #4573

Closed

Conversation

wesleycho
Copy link
Contributor

  • Add ng-disabled usage in template
  • Add tabindex to support to timepicker controls

This addresses #4569

@@ -50,3 +50,7 @@ All settings can be provided as attributes in the `<uib-timepicker>` or globally
* `max`
_(Defaults: undefined)_ :
Maximum time a user can select

* `timepicker-tabindex`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't we use tabindex here? And remove it from the timepicker host element if needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it, but I had a concern...but I can't remember it now - I am willing to go that route though for simplicity.

@wesleycho wesleycho force-pushed the feat/timepicker-accessibility branch 2 times, most recently from 445f358 to a6cdd6e Compare October 11, 2015 15:29
- Add ng-disabled usage in template
- Add `timepickerTabindex` attribute support for binding tabindex to
  timepicker controls
@wesleycho wesleycho force-pushed the feat/timepicker-accessibility branch from a6cdd6e to e0e5d71 Compare October 11, 2015 15:31
@Foxandxss
Copy link
Contributor

Not really my topic.

The only bit to talk here is that we shouldn't be supporting the deprecated directives. The point is to force people to upgrade and not fixing them is a good way to do so.

@wesleycho
Copy link
Contributor Author

This has nothing to do with deprecated directive support :) .

@Foxandxss
Copy link
Contributor

I know I know, I just said that tabs and accessibility is not something I can talk about.

@wesleycho wesleycho closed this in 4ebecbc Oct 11, 2015
@wesleycho wesleycho deleted the feat/timepicker-accessibility branch October 11, 2015 21:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants