Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Change $modalInstance to $uibModalInstance #4638

Closed
ravishivt opened this issue Oct 15, 2015 · 5 comments
Closed

Change $modalInstance to $uibModalInstance #4638

ravishivt opened this issue Oct 15, 2015 · 5 comments
Labels
component: modal
Milestone
0.14.3

Comments

@ravishivt
Copy link

Shouldn't this provider's name be updated to conform?
@pkozlowski-opensource
Copy link
Member

Yeh, we could do this for consistency.

@wesleycho
Copy link
Contributor

It should be noted that this is a breaking change - I'm fine with this breaking change. This could affect the regular modal service users since the code is not duplicated.

@wesleycho wesleycho added this to the 1.0.0 milestone Oct 16, 2015
@wesleycho
Copy link
Contributor

Scheduling this for 1.0 since this will be a breaking change with a bit of potential pain.

@wesleycho wesleycho modified the milestones: 0.14.3, 1.0.0 Oct 19, 2015
@wesleycho
Copy link
Contributor

Figured out a way to get this to work in 0.14.x and play nicely - will have PR up shortly.

@wesleycho wesleycho mentioned this issue Oct 19, 2015
Closed
@ravishivt
Copy link
Author

Great, thanks! I opened another similar request. #4670

@RobJacobs RobJacobs mentioned this issue Oct 23, 2015
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: modal
Projects
None yet
Milestone
0.14.3
Development

No branches or pull requests
3 participants
@pkozlowski-opensource @wesleycho @ravishivt