Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

uib-modal Trap focus doesn't work when keyboard: false option is provided #4990

Closed
wawyed opened this issue Dec 1, 2015 · 3 comments
Closed

Comments

@wawyed
Copy link
Contributor

wawyed commented Dec 1, 2015

This is caused by this line https://github.com/angular-ui/bootstrap/blob/master/src/modal/modal.js#L357

Most likely that check (modal.value.keyboard) should be inside the case 27: (escape key) and not surrounding the whole switch that also handles trap focus.

@wawyed wawyed changed the title uib-modal Trap focus doesn't work when keyboard: false options is provided. uib-modal Trap focus doesn't work when keyboard: false option is provided Dec 1, 2015
@wesleycho
Copy link
Contributor

You mean the check should be inside case 27 - that is the escape key, 9 is the tab key.

Would you like to file a PR for this?

@wawyed
Copy link
Contributor Author

wawyed commented Dec 1, 2015

Derp, sorry I mean case 27 escape key yes. I might to submit a PR for it but I'm quite busy at the moment. I might get some time next week.

@wesleycho
Copy link
Contributor

Just let me know - this should be easy to fix and I can fix it, but I think it'd be a nice contribution if you'd like.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants