This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(modal): fix copying from $scope #5048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleycho
force-pushed
the
fix/bindToController-copying
branch
3 times, most recently
from
069ea02
to
3ae6aab
Compare
- Fixes issue where `$scope` provided does not have properties present on controller instance due to $new resulting in the property on the prototype of the $scope copied from, which causes it to not be enumerable
wesleycho
force-pushed
the
fix/bindToController-copying
branch
from
3ae6aab
to
ae18a09
Compare
|
LGTM but I would change the titlte to "fix bindToController" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$scopeprovided does not have properties presenton controller instance due to $new resulting in the property on the
prototype of the $scope copied from, which causes it to not be
enumerable
This fixes #5039