This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(datepicker): correctly set minMode/maxMode #5093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correctly set `minMode` and `maxMode` for the datepicker popup - Fix documentation of `datepickerMode`, as it is bound to a property on $scope and not an attribute string value
|
The fix is nice, but I don't understand the doc change. I was thinking if I wanted to put quotes around values that are string. Perhaps I do. For the time being, remove the doc change and I will see what I want to do with that in all the other docs. |
|
Alright, will merge with the removal now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minModeandmaxModefor the datepicker popupdatepickerMode, as it is bound to a property on $scope and not an attribute string valueFix in action here.
This fixes #5090.