Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

colon notation for the uib prefix isn't supported for tab headings #5568

Closed
ivassiliev opened this issue Mar 2, 2016 · 1 comment
Closed

colon notation for the uib prefix isn't supported for tab headings #5568

ivassiliev opened this issue Mar 2, 2016 · 1 comment
Labels
component: tab severity: broken expected use type: bug
Milestone
1.2.3

Comments

@ivassiliev
Copy link

Bug description:

Hi, I found this while fixing some inconsistencies in our code:

The colon notation for the uib prefix isn't supported for tab headings, but is for other elements such as alert, angularjs also currently still supports both formats so there's some inconsistency here between what angularjs is supporting and what ui boostrap is supporting.

Thanks for looking.

Link to minimally-working plunker that reproduces the issue:

http://plnkr.co/edit/7SARpm4f3a0TSBTjaDhg

Version of Angular, UIBS, and Bootstrap

Angular: 1.5.0

UIBS: 1.2.1

Bootstrap: 3.3.6
@wesleycho
Copy link
Contributor

Can't say I like seeing anyone use : in their element names (seems foreign to anyone working in HTML, and rare), but I guess this is a bug.

@wesleycho wesleycho added this to the Backlog milestone Mar 2, 2016
@wesleycho wesleycho modified the milestones: 1.2.3, Backlog Mar 6, 2016
@wesleycho wesleycho mentioned this issue Mar 6, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: tab severity: broken expected use type: bug
Projects
None yet
Milestone
1.2.3
Development

Successfully merging a pull request may close this issue.

fix(tabs): support heading with : wesleycho/bootstrap
2 participants
@wesleycho @ivassiliev